Skip to content

Fix broken link#4762

Open
tobolar wants to merge 2 commits intomodelica:masterfrom
tobolar:fix4759-broken-link
Open

Fix broken link#4762
tobolar wants to merge 2 commits intomodelica:masterfrom
tobolar:fix4759-broken-link

Conversation

@tobolar
Copy link
Contributor

@tobolar tobolar commented Mar 10, 2026

Close #4759

@tobolar tobolar requested review from MartinOtter and beutlich March 10, 2026 11:13
@tobolar tobolar self-assigned this Mar 10, 2026
@tobolar tobolar added L: Mechanics.MultiBody Issue addresses Modelica.Mechanics.MultiBody documentation Issue addresses the documentation labels Mar 10, 2026
@beutlich
Copy link
Member

matrix-to-quat.pdf

Copy link
Member

@beutlich beutlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer to link to some file we have under control. So, what about

Enough options.

@tobolar
Copy link
Contributor Author

tobolar commented Mar 20, 2026

adding it directly to Modelica/Resources/Documentation/Mechanics (like we already have Modelica/Resources/Documentation/Electrical/Spice3/Spice_3f3_Users_Manual.pdf)

I like this since a user can access it directly.

@tobolar
Copy link
Contributor Author

tobolar commented Mar 20, 2026

@beutlich I changed it now as suggested. My two commits can be squashed on merge.

@beutlich beutlich enabled auto-merge (squash) March 21, 2026 10:13
@beutlich beutlich added the L: Resources Issue addresses Modelica/Resources (excl. C-Sources) label Mar 21, 2026
beutlich
beutlich previously approved these changes Mar 21, 2026
@maltelenz
Copy link
Contributor

Does MA have the rights to distribute the material?

@beutlich
Copy link
Member

beutlich commented Mar 23, 2026

Does MA have the rights to distribute the material?

Good point.

Copy link
Contributor

@maltelenz maltelenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting changes to prevent merging until it is clarified that MA has the right to distribute the document, or some other solution is chosen.

@beutlich beutlich dismissed their stale review March 23, 2026 20:51

Requesting changes to prevent merging until it is clarified that MA has the right to distribute the document, or some other solution is chosen.

@beutlich beutlich removed the L: Resources Issue addresses Modelica/Resources (excl. C-Sources) label Mar 23, 2026
/*
This is an optimized version of the quaternion conversion based on
this paper: https://d3cw3dd2w32x2b.cloudfront.net/wp-content/uploads/2015/01/matrix-to-quat.pdf
this paper: modelica://Modelica/Resources/Documentation/Mechanics/matrix-to-quat.pdf
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
this paper: modelica://Modelica/Resources/Documentation/Mechanics/matrix-to-quat.pdf
this paper: https://web.archive.org/web/20170718214714/https://d3cw3dd2w32x2b.cloudfront.net/wp-content/uploads/2015/01/matrix-to-quat.pdf

<li>January 2021 by Jakub Tobolar<br>
reimplemented for more efficient and numerically stable algorithm according to
<a href=\"https://d3cw3dd2w32x2b.cloudfront.net/wp-content/uploads/2015/01/matrix-to-quat.pdf\">https://d3cw3dd2w32x2b.cloudfront.net/wp-content/uploads/2015/01/matrix-to-quat.pdf</a>.
<a href=\"modelica://Modelica/Resources/Documentation/Mechanics/matrix-to-quat.pdf\">matrix-to-quat.pdf</a>.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<a href=\"modelica://Modelica/Resources/Documentation/Mechanics/matrix-to-quat.pdf\">matrix-to-quat.pdf</a>.
<a href=\"https://web.archive.org/web/20170718214714/https://d3cw3dd2w32x2b.cloudfront.net/wp-content/uploads/2015/01/matrix-to-quat.pdf\">matrix-to-quat.pdf</a>.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Issue addresses the documentation L: Mechanics.MultiBody Issue addresses Modelica.Mechanics.MultiBody

Projects

None yet

3 participants